Improving indexing of solar weather file based on dt in input .yaml file #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging NREL/develop into local branch pre-pull-request
|
All tests are passing locally. |
Thanks @brookeslawski ! See this pull request for attempts (which were ultimately unsuccessful) to get these failing tests on github to clear. For the time being, we'll just ensure the tests pass locally. |
|
Per Misha's suggestion, added a |
brookeslawski
commented
Aug 20, 2024
| @@ -238,7 +238,7 @@ def receive_amrwind_data(self): | |||
| # Assign Py_sim outputs | |||
| if self.main_dict["py_sims"]: | |||
| self.main_dict["py_sims"]["inputs"]["available_power"] = sum(turbine_power_array) | |||
| print("sim_time_s_amr_wind = ", sim_time_s_amr_wind) | |||
| # print("sim_time_s_amr_wind = ", sim_time_s_amr_wind) | |||
There was a problem hiding this comment.
cleaning up print statements that I had added long ago
genevievestarke
approved these changes
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the way that
solar_pysam.pyselects data from the input solar weather file. The input solar weather file contains timeseries weather data at a temporal resolution that may or may not be the same asdtin the input .yaml file. This pull request ensures thatsolar_pysam.pyis selecting weather data at the correct timestamp. For example, if the input solar weather file contains data at every 0.5 second, butdt = 1.0s in the .yaml file, the solar module will select data at every second after the timestamp of the first row of data.If
dtis not equal to or a multiple (>1) of the temporal resolution in the input solar weather file, a warning will print to the hercules log file.This pull request does interpolate input data if
dtis smaller than the temporal resolution in the input solar weather file. This interpolation should happen outside of hercules as part of pre-processing. An example of this pre-processing is included inexample_case_folders/07_floris_standin_and_solar_pysam/read_solar_precursor_data.ipynb.I have also improved the handling of timezones and added a warning that timezone must be included in the input solar weather file timestamps.
Also included are the input weather files from the ARM experiment and from the Flatirons campus, which were used for testing.