Add external controls for solar PySAM module #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
genevievestarke
approved these changes
May 13, 2024
brookeslawski
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to provide a control setpoint to the solar module. The 07_floris_standin_and_solar_pysam example still runs as expected, and I've added a small test to make sure that the control setpoint is adhered to when passed, so I think this is ready for review.
NOTE: I've also saved the AMR wind speed (or stand-in wind speed) on the Hercules main dict for use in controllers that need (an estimate of) the free stream wind speed.