Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

brookeslawski · 2024-04-12T22:20:11Z

1. Solar controller

Implementing a simple PV plant controller that trims any PV plant power output above the setpoint at each timestep. This is similar to what pysam does. The "curtailment" is applied uniformly to the entire PV plant.

Requires an input power setpoint signal, which is read in through the input file field external_data_file.

In the future, this power setpoint might be calculated internally in hercules and this controller will need to be modified to handle that input.

2. FLORIS stand-in

The AMR-Wind stand-in was causing the errors shown below.

FLORIS was determined to be a better stand-in anyway, and was easy to implement, so the FLORIS stand-in replaced the AMR-Wind stand-in.

…solar-pysam tried to push to origin solar-pysam but wasn't able to because this branch was behind the remote by a commit

Merging develop into local branch to prepare for PR back to NREL develop

brookeslawski · 2024-04-15T15:10:08Z

example_case_folders/07_amr_wind_standin_and_solar_pysam/test_read_output.ipynb

No big changes, just the path leading to the output file and a change in an output variable name

misi9170 · 2024-04-15T15:15:51Z

max-power-prediction-OK-pysam.ipynb

Is this file supposed to be included with this PR?

Nope, deleting this. Thanks.

misi9170 · 2024-04-15T15:18:00Z

hercules/python_simulators/solar_pysam.py

-        print("sim_time_s = ", inputs["py_sims"]["inputs"]["sim_time_s"])
-        sim_timestep = int(inputs["py_sims"]["inputs"]["sim_time_s"] / self.dt)
+        # sim_time_s = inputs["py_sims"]["inputs"]["sim_time_s"]
+        sim_time_s = inputs["time"]


This change (from inputs["py_sims"]["inputs"]["sim_time_s"] to inputs["time"] is causing the test_step test in tests/solar_pysam_test.py to fail. Possibly, the step_inputs dictionary in tests/solar_pysam_test.py just need to be updated to add the "time" field?

Fixed! Thanks for pointing this out

misi9170 · 2024-04-15T15:23:35Z

example_case_folders/07_floris_standin_and_solar_pysam/hercules_controller_input_000.yaml

+
+controller:
+
+external_data_file: solar_power_reference.csv


This file is missing from the repo, I think

misi9170 · 2024-04-15T15:26:04Z

example_case_folders/07_floris_standin_and_solar_pysam/hercules_input_000.yaml

This file is maybe not used?

In the batch_script, I wanted to include the option to run hercules without the pv controller, which uses hercules_input_000.yaml as well as the option to run with the pv controller, which uses hercules_controller_input_000.yaml. So left both files in there. Is that ok?

README updated to clarify these options

misi9170 · 2024-04-15T15:34:34Z

Hi @brookeslawski! I left a handful of small comments, but perhaps I'm a little confused about the files in the 07_floris_standin_and_solar_pysam. It seems that there is a bit of a mix in there of files that are needed to run this example, and files that maybe are just carry-overs from when it was 07_amr_wind_standin_and_solar_pysam, several of which I think are no longer used.

Did you mean to leave those in? Is the intention that the user could run the example with the AMR-Wind standin, as well as with the FLORIS standin?

…solar-pysam tried to push, but said there were changes in remote that weren't local so now i'm pulling.

brookeslawski · 2024-04-15T16:42:35Z

hercules/emulator.py

        times = np.arange(
-            self.helics_config_dict["starttime"], self.helics_config_dict["stoptime"], self.dt
+            self.helics_config_dict["starttime"],
+            self.helics_config_dict["stoptime"]+(2*self.dt),


Changed this to create times variable that includes the stoptime + one more timestep. np.arange is half-open, which does not include end and thus was causing errors when hercules was looking for a setpoint at the last timestep, but not finding it even though it was in the input external_data_file

brookeslawski · 2024-04-15T17:08:41Z

Hi @brookeslawski! I left a handful of small comments, but perhaps I'm a little confused about the files in the 07_floris_standin_and_solar_pysam. It seems that there is a bit of a mix in there of files that are needed to run this example, and files that maybe are just carry-overs from when it was 07_amr_wind_standin_and_solar_pysam, several of which I think are no longer used.

Did you mean to leave those in? Is the intention that the user could run the example with the AMR-Wind standin, as well as with the FLORIS standin?

Hi @misi9170 - Thank you for the review. I've deleted the amr_wind_standin files, which was just the hercules_runscript_amr_standin.py

…test_read_output.ipynb

misi9170

Thanks for addressing my comments, @brookeslawski ! I've been able to run the example in both controlled and uncontrolled configurations. I made a couple of small changes, hopefully you're happy (but feel free to revert if not):

Removed one of the &s in batch_script.sh, because I found this was causing the script not to terminate properly (and it was my fault that that went in in the first place!)
Added handling to the test_read_output.ipynb notebook for when running the uncontrolled case

genevievestarke

Looks good to me! I left a few comments that don't really need to be addressed, just some thoughts. Otherwise, good to merge!

genevievestarke · 2024-04-15T22:57:18Z

example_case_folders/07_floris_standin_and_solar_pysam/solar_power_reference.csv

Just noticing that this file is really long. Do we need all of it, or can we shorten it for example purposes?

I do have a five-timestep version of this file for testing, but I left the longer one in there to be able to demonstrate more of a variation in the setpoint signal. It doesn't take long to run, and you can always change the stoptime to be something shorter for quicker tests. The input stoptime doesn't need to match the time in this file.

genevievestarke · 2024-04-15T22:58:01Z

example_case_folders/07_floris_standin_and_solar_pysam/test_read_output.ipynb

I just edited the results plot so that all of the units were consistent. I don't know if you can see the changes on github though.

brookeslawski and others added 30 commits November 27, 2023 09:55

created dummy example for amr wind dummy + solar

31705ee

final commit before creating feature branch

471cb76

standalone solar pysam example

dead7ce

working standalone example of solar pysam model

97f0a60

removed time as explicit input in step

79f16e6

working example of solar pysam and hercules (but pysam has a bug)

58ec136

changing hardcoded stoptime of 100 s to 1000 s to demo solar module

0957591

cleaning before pull request review of misha's changes

19299db

working solar pysam example with test amr wind

14c4e38

adding updated results in jupyter notebook

46e161e

merging NREL/develop into local branch

cc4ee8c

trying to run after git pull of develop

466bbd3

solar model runs successfully, but there is a time issue

95618db

correcting irradiance field and removing unnecessary comments

1c94d37

removing unnecessary files

36e105a

removing test amr wind and solar example, saving for separate PR

44a7c6e

adding environment yaml file needed for pysam

bc67bcf

updating setup and docs to include pysam and restrict python version

4e43583

adding missing csv weather file

41e5a47

Minor changes for running the code

1b07044

Minor cleanup in example.

c4289bb

remove environment.yml

f8f76c0

Merge in Misha's changes

a2d73ce

merging NREL/hercules:develop into local branch

68ab725

Merge branch 'solar-pysam' of github.com:brookeslawski/hercules into …

c575011

…solar-pysam tried to push to origin solar-pysam but wasn't able to because this branch was behind the remote by a commit

adding solar module unit tests

0be7f2a

adding relative path for pytest functionality

74acc0a

correcting ruff formatting and except

1e38644

more ruff formatting

724112c

Merge branch 'develop' of github.com:NREL/hercules into solar-pysam

ad52112

Merging develop into local branch to prepare for PR back to NREL develop

cleanup

42ebbd7

brookeslawski commented Apr 15, 2024

View reviewed changes

Ruff compatibility.

d6e4616

misi9170 reviewed Apr 15, 2024

View reviewed changes

brookeslawski added 4 commits April 15, 2024 09:45

cleaning up files

2dc720f

Merge branch 'solar-pysam' of github.com:brookeslawski/hercules into …

e50904e

…solar-pysam tried to push, but said there were changes in remote that weren't local so now i'm pulling.

fixing errors in tests

d8aa1f2

fixing standalone example

908ca7a

brookeslawski commented Apr 15, 2024

View reviewed changes

brookeslawski added 2 commits April 15, 2024 10:56

ruff changes

43895cc

removing amr_wind standin run script

b018ada

brookeslawski and others added 4 commits April 15, 2024 11:23

adding external_data_file solar_power_reference.csv

757490d

clarifing controller input in README and fixing dc_power_mw error in …

67cbc22

…test_read_output.ipynb

Handling for when power_setpoints not available.

10f36fa

Remove & on second call so that script terminates as expected.

67e6f94

misi9170 self-requested a review April 15, 2024 19:17

misi9170 approved these changes Apr 15, 2024

View reviewed changes

Updating units for results plots

6f9bed1

genevievestarke approved these changes Apr 15, 2024

View reviewed changes

genevievestarke added 2 commits April 16, 2024 09:38

Make ruff compliant

1972e79

Make ruff compliant 2

b739314

genevievestarke merged commit 6f9f4e3 into NREL:develop Apr 16, 2024
6 checks passed

genevievestarke linked an issue Apr 16, 2024 that may be closed by this pull request

Create simple solar controller based on simple battery controller #94

Closed

misi9170 mentioned this pull request Apr 18, 2024

Provide external driving signals to various py_sims #82

Open

misi9170 mentioned this pull request Sep 27, 2024

Hercules v1.1 #116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

brookeslawski commented Apr 12, 2024 •

edited

Loading

brookeslawski Apr 15, 2024

misi9170 Apr 15, 2024

brookeslawski Apr 15, 2024

misi9170 Apr 15, 2024

brookeslawski Apr 15, 2024

misi9170 Apr 15, 2024

brookeslawski Apr 15, 2024

misi9170 Apr 15, 2024

brookeslawski Apr 15, 2024

brookeslawski Apr 15, 2024

misi9170 commented Apr 15, 2024 •

edited

Loading

brookeslawski Apr 15, 2024

brookeslawski commented Apr 15, 2024

misi9170 left a comment

genevievestarke left a comment

genevievestarke Apr 15, 2024

brookeslawski Apr 16, 2024

genevievestarke Apr 15, 2024


		controller:

		external_data_file: solar_power_reference.csv

Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

Adding solar controller and replacing AMR-Wind standin with FLORIS standin in example 07 #104

Conversation

brookeslawski commented Apr 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misi9170 commented Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

brookeslawski commented Apr 15, 2024

misi9170 left a comment

Choose a reason for hiding this comment

genevievestarke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brookeslawski commented Apr 12, 2024 •

edited

Loading

misi9170 commented Apr 15, 2024 •

edited

Loading