[BUGFIX] Create reproducible version of random search layout optimizer for testing #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that after the changes, I still get the same result (as on the develop branch) running examples/examples_layout_optimization/003_genetic_random_search.py if I fix the random seed to the |
paulf81
approved these changes
Jul 10, 2024
This was referenced Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #936 , the regression tests for the random search layout optimizer can sometimes fail. I believe that the cause for this is that the optimizer is run for one second during the test; however, depending on the machine, it may take more or less steps over that period.
This PR alters the
LayoutOptimizationRandomSearchcode to make it modular, and then adds a debugging version of the optimization routine that will take a fixed number of steps (in particular, 100 random perturbations per generation, 1 individual per generation, and 2 generations).This should enable reproducible regression test results.