Add test for v3_to_v4 input file converters #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
requested changes
Apr 14, 2024
tests/convert_v3_to_v4_test.py
Outdated
| file.write(filedata) | ||
|
|
||
| # Now confirm that the converted file can be loaded by FLORIS | ||
| _ = FlorisModel(filename_v4_floris) |
There was a problem hiding this comment.
I think we should also confirm that it runs, because I'm not 100% sure that just loading it catches all possible missing fields? I don't think we should set anything, just instantiate to fmodel and run.
There was a problem hiding this comment.
Good suggestion! Adding now
misi9170
reviewed
Apr 15, 2024
tests/convert_v3_to_v4_test.py
Outdated
| # Run the converter on the floris file | ||
| os.system(f"python convert_floris_input_v3_to_v4.py {filename_v3_floris}") | ||
|
|
||
| # Go through the file filename_v4_turbine and where the place-holder string "XXXXX" is found |
There was a problem hiding this comment.
Sorry, just noticed maybe a typo here: should this comment be referring to filename_v4_floris rather than filename_v4_turbine?
misi9170
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI testing of v3 to v4 conversions
I was thinking as we add features to v4 it'll be good to have some testing that the converter from v3 to v4 is keeping up if we we add new aspects to v4. The test I added works by:
One special case handled is that the v3 yaml points to a turbine_type "XXXXX" which is replaced after conversion with a !include pointing to the newly created v4 turbine file. Originally I had the !include in the v3 input but this gets merged to early and the whole turbine file ends up in the v4 floris yaml.
Related issue
Inspired by #878