Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fix yaw to nominal wind direction #850

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Mar 20, 2024

Add fix_yaw_to_nominal_direction

This pull request re-includes the option in the UncertainFlorisModel to fix the yaws into the frame of the nominal wind direction. Currently for example, if yaw angle is 0, and wind direction is 270, uncertainty is computed over a range of wind direction while holding yaw = 0. This pull request adds the flag fix_yaw_to_nominal_direction, which changes the computations such that the yaw is modified to always be 0 relative to the nominal 270 degrees (so it would be +3 when checking 267 for nominal 270)

Specific changes:

  • Incorporates the changes and bugfixes to UncertainFlorisModel already in Refactor examples #843
  • Adds the fix_yaw_to_nominal_direction functionality
  • Adds tests for the new functionality

@paulf81 paulf81 added the v4 Focus of FLORIS v4 label Mar 20, 2024
@paulf81 paulf81 added this to the v4.0 milestone Mar 20, 2024
@paulf81 paulf81 self-assigned this Mar 20, 2024
Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't related to the changes in the current PR, but I'm having a hard time understanding what the UncertainFlorisModel does. For example, how are wind speed and TI resolution used? Does uncertainty get modeled for those variables in addition to wind direction? Also, do Gaussian weights get applied to the power at the wd_sample_points? I'd suggest some additional explanation in the class docstring.

direction? When False,
the yaw angle is the same across the sampled wind directions. When True, the yaw
angle is fixed to the nominal wind direction and so of offset by the negative of
wind direction offset. Defaults to False.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is a little confusing to me. Could this say "When False, the yaw misalignment is the same across the sampled wind directions. When True, the turbine orientation is fixed to the nominal wind direction such that the yaw misalignment changes depending on the sampled wind direction."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@rafmudaf rafmudaf changed the title Add fix_yaw_to_nominal_direction Allow to fix yaw to nominal wind direction Mar 21, 2024
@ejsimley
Copy link
Collaborator

Sorry, accidentally rerequested review from @rafmudaf, who had approved already.

Copy link
Collaborator

@ejsimley ejsimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra documentation looks good

@paulf81 paulf81 merged commit ecfe9f8 into NREL:v4 Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Focus of FLORIS v4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants