[BUGFIX] Coordinates getter on Farm class #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
changed the title
|
Note that a similar bugfix will be needed on the v4 branch, although this may be resolved by merging develop back into v4. |
rafmudaf
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue raised in #833 that getter
Farm.coordinatesfails whenhub_heightshas been expanded to dimensions (n_wind_directionsxn_wind_speedsxn_turbines) (from its original shape ofn_turbines).After considering the two possible fixes mentioned in #833, I've decided to go with the latter, because it affects less of the code. When investigating the former option (which removes the broadcasting of
hub_heightsto be 3-dimensional in the first place), I found that I could remove the broadcast of bothhub_heightsandrotor_diametersand still pass tests, but removing the broadcast ofturbine_type_mapcauses failures. For consistency and minimal invasiveness, I've gone with a higher-level patch here.