Clarify turbine definition terms #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafmudaf
reviewed
Feb 21, 2024
| @@ -180,8 +180,8 @@ class CosineLossTurbine(BaseOperationModel): | |||
| """ | |||
| Static class defining an actuator disk turbine model that may be misaligned with the flow. | |||
| Nonzero tilt and yaw angles are handled via cosine relationships, with the power lost to yawing | |||
| defined by the pP exponent. This turbine submodel is the default, and matches the turbine | |||
| model in FLORIS v3. | |||
| defined by the cosine_loss_exponent_yaw. This turbine submodel is the default, and matches the | |||
There was a problem hiding this comment.
The way this sentence reads is unclear. I suggest either rephrasing to plane english such as "defined the the corresponding cosine loss exponent for yaw and tilt".
rafmudaf
reviewed
Feb 21, 2024
floris/simulation/turbine/turbine.py
Outdated
| @@ -130,7 +130,7 @@ def power( | |||
| """ | |||
| # TODO: Change the order of input arguments to be consistent with the other | |||
| # utility functions - velocities first... | |||
| # Update to power calculation which replaces the fixed pP exponent with | |||
| # Update to power calculation which replaces the fixed cosine_loss_exponent_yaw exponent with | |||
There was a problem hiding this comment.
Similar to in the operation models module, this might be more clear in plane english
| @@ -57,8 +57,8 @@ | |||
| valid_properties = [ | |||
| "generator_efficiency", | |||
There was a problem hiding this comment.
Yes---this one property (generator_efficiency) is still needed for the conversion of a v3 turbine to a v4 turbine, so is kept at this stage. However, the output v4 turbine yaml will not contain generator_efficiency (it is used in build_cosine_loss_turbine_dict() and then discarded).
rafmudaf
approved these changes
Feb 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turbine definition yamls contain a couple of terms that were unclear and needed clarification. This discussion began with my misunderstanding of the key
pT(see Further discussion needed on #770), but also extends topTand the now-unusedgenerator_efficiencykey (following #765).Accordingly, this PR:
pPtocosine_loss_exponent_yawon the turbine definition yamls and throughout the codepTtocosine_loss_exponent_tilton the turbine definition yamls and throughout the codegenerator_efficiencykey on the turbine definition yamls, and adds comments to turbine models in the turbine_library to indicate the generator efficiencies used in generating the absolute power curves.There is one loose end in turbine.py---the multidimensional cp ct table still specifies a Cp value rather than an absolute power (again, see Further discussion needed on #770), so there is still a need for generator efficiency. For now, I have hardcoded the efficiency of the NREL 5MW, which enables the tests to pass. However, @bayc is currently in the process of switching the multidimensional turbine definitions to an absolute power rather than a cp value, which will remove the need for generator efficiency entirely.