Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove secondary effects from TurboPark model #813

Merged

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Feb 20, 2024

During the transition to 4d structures (#764), the secondary effects (for wake steering) in the TurboPark model were not converted (as these are not tested and not in the examples). Speaking to @bayc and @paulf81, the secondary effects were never validated, and we decided it's best to remove the capabilities and instead raise NotImplementedErrors.

To recreate the issue, take the following steps:

  1. Change the enable_secondary_steering, enable_yaw_added_recovery, and enable_transverse_velocities to true in examples/inputs/turbopark.yaml.
  2. Run (from the examples/ directory)
from floris.tools import FlorisInterface
fi = FlorisInterface("inputs/turbopark.yaml")
fi.calculate_wake()

On the v4 branch, this raises an error that appears to be to do with dimensions. This PR changes this to raise NotImplementedErrors.

@misi9170 misi9170 added bug Something isn't working v4 Focus of FLORIS v4 labels Feb 20, 2024
@rafmudaf rafmudaf merged commit d4c6a1f into NREL:v4 Feb 21, 2024
8 checks passed
@misi9170 misi9170 deleted the v4-ms/bugfix_remove-turbopark-secondary-effects branch February 21, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4 Focus of FLORIS v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants