[BUGFIX] Remove secondary effects from TurboPark model #813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the transition to 4d structures (#764), the secondary effects (for wake steering) in the TurboPark model were not converted (as these are not tested and not in the examples). Speaking to @bayc and @paulf81, the secondary effects were never validated, and we decided it's best to remove the capabilities and instead raise
NotImplementedError
s.To recreate the issue, take the following steps:
enable_secondary_steering
,enable_yaw_added_recovery
, andenable_transverse_velocities
totrue
in examples/inputs/turbopark.yaml.On the v4 branch, this raises an error that appears to be to do with dimensions. This PR changes this to raise
NotImplementedError
s.