Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference turbine model data #767

Closed
wants to merge 40 commits into from

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Dec 18, 2023

In converting from Cp to power curves as the standard for v4, we also noted that the data for some of the models in turbine library (most notably, the NREL 5MW) are out of date.

This pull request would update that data.

Impacted areas of the software

  • turbine_library/ (turbine models updated; v3 models archived in legacy_v3 subdirectory; x_20MW turbine removed from library for v4)
  • examples/inputs_floating (turbine models updated)
  • tests/ (regression tests updated; minor changes to some turbine unit tests to reflect changes in curves and elimination of x_20MW turbine) SEE NOTE BELOW

For discussion

A couple of important issues arise in this pull request, which may mean that we do not want to merge this as is. I will mark them complete once if/when we resolve these issues.

  • Regression tests for small_grid_rotations are failing, because the second-through-last turbines in the top column no longer produce the same power as the second turbine. It is not clear that this should be the case anyway. @rafmudaf and I discussed this to some extent---this is not a deal-breaker, but should be updated if we'd like to proceed with merging.
  • Updates to the reference turbine data, and in particular, the NREL 5MW, will change outputs from examples. I will attempt to document the extent of these changes. This shouldn't affect the default wake model tunings, but as outputs will change, the two effects (turbine model parameters and wake model parameters) could be conflated. I will update this shortly with a graphic to show the changes to the NREL 5MW data curves.

…MW turbine only, will remove prior to merge into v4 branch.
@misi9170
Copy link
Collaborator Author

misi9170 commented Jan 3, 2024

Closing as superseded by #771

@misi9170 misi9170 closed this Jan 3, 2024
@misi9170 misi9170 deleted the v4-ms/v4-reference-turbines branch February 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant