Bug fix: Enable mulit-dimensional turbines for turbine interactions #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHammond2
added
bug
|
Thanks @RHammond2! |
rafmudaf
approved these changes
Dec 5, 2023
|
@bayc Your eyes are probably more critical on this one |
|
I'm going to merge this since a few other pull requests depend on it, but @bayc feel free to comment here if you have any feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Multi-Dimensional Turbines in the Turbine Preview Moduel
This PR updates the
TurbineInterfaceandTurbineLibraryconvenience features to enable multi-dimensional turbines in the power and thrust curve calculations and plots.Related issue
This is related to the following issues and pull requests:
Additionally, the GH Actions for documentation build is failing on the
turbine_interaction.ipynbnotebook.Impacted areas of the software
floris/turbine_library/turbine_preview.py:Cphas been removed to prepare its future deprecation.TurbineMultidimensional,power_multi_dim, andCt_multidimare now used appropriately for multi-dimensional turbines.floris/simulation/turbine.py:power: Updated the typing and docstring to match the expected data type and reduce confusion for future users.floris/simulation/turbine_multi_dim.py:condition_keysto track what the dimensions actually are as a convenient way to not reload the data, just to obtain the first x column names in the power data file.floris/turbine_library/iea_15MW_multi_dim_cp_ct.yaml: corrected the file name to work with updated library assumptions from Fix path dependency inconvert_to_pathtest #749.docs/turbine_interaction.ipynb: Updated to have Cp removed.Additional supporting information
N/A
Test results, if applicable
All tests pass.