Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid-class tidying #751

Merged
merged 13 commits into from
Dec 7, 2023
Merged

Grid-class tidying #751

merged 13 commits into from
Dec 7, 2023

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    3320057 View commit details
    Browse the repository at this point in the history
  2. Rename grid diameter array

    Initially, this variable held a single reference turbine diameter value, but it was subsequently changed to contain the diameter of all wind turbines. The name change simply reflects it’s actual use.
    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4c49f8d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd728b5 View commit details
    Browse the repository at this point in the history
  4. Use numpy array for coordinates

    Rather than a list of Vec3. This supports creating a layout from a dictionary of exported modules and classes rather than having to do the additional step of converting to Vec3.
    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0acd59c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c92d859 View commit details
    Browse the repository at this point in the history
  6. Test grid to and from dict functionality - disabled

    This requires setting the comparison method in the TurbineGrid and Grid classes. While this can be done with
    field(eq=cmp_using(eq=np.array_equal))
    this adds a lot of additional code to the attribute declarations and makes them difficult to read. Holding off for now but I wanted to leave the test in place for future reference.
    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    5177817 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0d584ea View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d308076 View commit details
    Browse the repository at this point in the history
  9. Remove the Vec3 class

    After switching the Grid coordinates from Vec3 to Numpy arrays, it turned out this wasn’t really used anymore.
    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c57be4f View commit details
    Browse the repository at this point in the history
  10. Disable filter_convert function

    While this was useful early in the v3 redesign, we’ve converged to a design where this is no longer used.
    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f90108e View commit details
    Browse the repository at this point in the history
  11. Fix Vec3 reference

    rafmudaf committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    83e8a4d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Fix syntax and typo

    rafmudaf committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    36c9140 View commit details
    Browse the repository at this point in the history
  2. Remove trailing whitespace

    rafmudaf committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a1a7a51 View commit details
    Browse the repository at this point in the history