-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid-class tidying #751
Merged
Merged
Grid-class tidying #751
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3320057 - Browse repository at this point
Copy the full SHA 3320057View commit details -
Initially, this variable held a single reference turbine diameter value, but it was subsequently changed to contain the diameter of all wind turbines. The name change simply reflects it’s actual use.
Configuration menu - View commit details
-
Copy full SHA for 4c49f8d - Browse repository at this point
Copy the full SHA 4c49f8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd728b5 - Browse repository at this point
Copy the full SHA dd728b5View commit details -
Use numpy array for coordinates
Rather than a list of Vec3. This supports creating a layout from a dictionary of exported modules and classes rather than having to do the additional step of converting to Vec3.
Configuration menu - View commit details
-
Copy full SHA for 0acd59c - Browse repository at this point
Copy the full SHA 0acd59cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c92d859 - Browse repository at this point
Copy the full SHA c92d859View commit details -
Test grid to and from dict functionality - disabled
This requires setting the comparison method in the TurbineGrid and Grid classes. While this can be done with field(eq=cmp_using(eq=np.array_equal)) this adds a lot of additional code to the attribute declarations and makes them difficult to read. Holding off for now but I wanted to leave the test in place for future reference.
Configuration menu - View commit details
-
Copy full SHA for 5177817 - Browse repository at this point
Copy the full SHA 5177817View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d584ea - Browse repository at this point
Copy the full SHA 0d584eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d308076 - Browse repository at this point
Copy the full SHA d308076View commit details -
After switching the Grid coordinates from Vec3 to Numpy arrays, it turned out this wasn’t really used anymore.
Configuration menu - View commit details
-
Copy full SHA for c57be4f - Browse repository at this point
Copy the full SHA c57be4fView commit details -
Disable filter_convert function
While this was useful early in the v3 redesign, we’ve converged to a design where this is no longer used.
Configuration menu - View commit details
-
Copy full SHA for f90108e - Browse repository at this point
Copy the full SHA f90108eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83e8a4d - Browse repository at this point
Copy the full SHA 83e8a4dView commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 36c9140 - Browse repository at this point
Copy the full SHA 36c9140View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a7a51 - Browse repository at this point
Copy the full SHA a1a7a51View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.