-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add multidimensional Cp/Ct turbine definition support #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulf81
reviewed
Oct 18, 2023
paulf81
reviewed
Oct 18, 2023
paulf81
reviewed
Oct 18, 2023
rafmudaf
reviewed
Oct 24, 2023
bayc
force-pushed
the
feature/multidimensional_cp_ct
branch
from
October 26, 2023 02:53
326f1c8
to
6057a7e
Compare
rafmudaf
approved these changes
Oct 26, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multidimensional Cp/Ct turbine definition support
This PR adds support for turbine Cp/Ct definitions that depend on an arbitrary number of external variables. This is accomplished by the user supplying Cp/Ct tables for any number of conditions. Interpolants are then created for all the conditions and the interpolant nearest to the defined conditions at the time of computation is selected and used.
Related issue
resolves #619
Impacted areas of the software
Most new code was confined to
floris/simulation/turbine_multi_dim.py
, with small changes in several other simulation files.Additional supporting information
Explanation of how to use these new features are included in the example
30_multi_dimensional_cp_ct.py
.To use this functionality, a turbine with a multi-dimensional Cp/Ct definition must be defined, along with
multidim_conditions
in theflow_field
section of the input file. A new solver is used, paired with themultidim_cp_ct
velocity deficit model, which used the gch model in its entirety, with some small changes required to down select the correct Ct and power interpolation functions. Examples for all of this are included in30_multi_dimensional_cp_ct.py
.Currently, the
multdim_conditions
supplied are considered global and do not support defining local conditions through the farm. The example showcases Cp/Ct values that depend on wave periodTp
and wave heightHs
, paired with the floating turbine capabilities in FLORIS. Thus, the user must definemultidim_conditions
for bothTp
andHs
. These conditions will then be used internally in a nearest-neighbor selection process to choose the Ct and power interpolants to use.Test results, if applicable
All tests pass, with an additional unit test added for the multi-dimensional Cp/Ct capbilities, found at
tests/turbine_multi_dim_unit_test.py
.