Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geometric yaw code for rough yaw optimization (in layout optimization) #681

Merged
merged 37 commits into from
Aug 15, 2023
Merged

Add geometric yaw code for rough yaw optimization (in layout optimization) #681

merged 37 commits into from
Aug 15, 2023

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Jul 12, 2023 •
edited
Loading

This pull request incorporates code from @pjstanle (https://github.com/pjstanle/GeometricYaw) to provide a rough estimate of optimal wake steering angles based purely on wind farm layout and wind direction (i.e., avoiding any wake calculations). See also https://wes.copernicus.org/preprints/wes-2023-1/

This is then incorporated as an option in the layout optimization routines so that efficient coupled layout and yaw optimizations can be conducted.

All source code changes are in the tools/ subdirectory. These changes touch the yaw optimization and layout optimization classes.

A new example (16c) is added to demonstrate the use of the geometric yaw optimization routine within the layout optimization routine.

Addresses #621
Tests pass.

Ready for review.

misha and others added 24 commits June 21, 2023 12:23
Avoid error of negative speeds when turbines close together (in near …
10cda68 
…wake).
Rough call to PJs geometric yaw code.
cb31344
Hacky way to get heterogenous flow to run in SR. Needs further valida…
cdbf302 
…tions.
@misi9170
Allow power interpolation values outside of range (set to zero).
8d3b0ed
@misi9170
updates to base class, scipy class, and SR class to handle heterogene…
db04ade 
…ous inflows during yaw optimization.
@misi9170
Formating w ruff.
8cb0abc
@misi9170
Moving warning from power() to get_turbine_powers() on FlorisInterface.
9c5d199
@misi9170
Merging in develop, updates on hetinflow.
705abbb
@misi9170
Undoing bad merge.
156833c
@misi9170
WIP commit.
ce5f344
@misi9170
Moving plt.show() calls to the running script so that code doesnt han…
5873ee9 
…g unexpectedly.
@misi9170
Scipy version runs as expected.
7b42fc5
@misi9170
PyOptSparse version now in.
547c9d0
@misi9170
Removing looping in _process_layout.py
0048218
@misi9170
Ruffing.
2e4c9c4
@misi9170
Add needed import.
ca4091f
@misi9170
Update layout optimization example with option to include geoyaw; sav…
a9d0f06 
…e geoyaw angles on the layout opt object for access after optimization complete.
@misi9170
Minor documentation improvements/
1599c49
@misi9170
Ruffing fix.
0f00d68
@misi9170
Moving geometric yaw code to a new yaw optimization class.
4ec7b7a
@misi9170
Switching from calling layout-specific geometric yaw optimizer to a g…
ae35b26 
…eneral geometric yaw optimizer.
@misi9170
Removing replaced geometric yaw code.
2e4743e
@misi9170
Ruffing.;
a0aeac5
@misi9170
Merging develop
77d30f5
@misi9170 misi9170 added the enhancement An improvement of an existing feature label Jul 12, 2023
@misi9170 misi9170 marked this pull request as draft July 13, 2023 17:07
@misi9170 misi9170 marked this pull request as ready for review August 8, 2023 23:56
@misi9170
Copy link
Collaborator Author

misi9170 commented Aug 8, 2023

@rafmudaf @paulf81 after some delay, this is ready for review. @pjstanle , it would also be great to get your feedback if you have any!

paulf81
paulf81 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and ran and reviewed the examples, all looks great!! Thanks @misi9170

@misi9170 misi9170 added this to the v3.5 milestone Aug 15, 2023
@misi9170 misi9170 merged commit db958c4 into NREL:develop Aug 15, 2023
5 checks passed
@misi9170 misi9170 mentioned this pull request Aug 15, 2023
Closed
@rafmudaf rafmudaf mentioned this pull request Oct 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulf81 paulf81 paulf81 approved these changes

@rafmudaf rafmudaf rafmudaf approved these changes

@pjstanle pjstanle Awaiting requested review from pjstanle

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature floris.optimization
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@misi9170 @paulf81 @rafmudaf