Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Fix error message in FromDictMixin #637

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Bug fix: Fix error message in FromDictMixin #637

merged 1 commit into from
Apr 25, 2023

Conversation

RHammond2
Copy link
Collaborator

f-strings require the f!

This PR adds in a missing leading f to the f-string in the FromDictMixin.from_dict error message for missing class parameters..

Related issue

N/A, I just found the bug doing other work.

Impacted areas of the software

floris.type_dec.FromDictMixin

Additional supporting information

N/A

Test results, if applicable

N/A

@RHammond2 RHammond2 added the bug Something isn't working label Apr 25, 2023
@RHammond2 RHammond2 added this to the v3.4 milestone Apr 25, 2023
@RHammond2 RHammond2 requested a review from rafmudaf April 25, 2023 20:51
@RHammond2 RHammond2 changed the base branch from main to develop April 25, 2023 20:51
@RHammond2 RHammond2 marked this pull request as ready for review April 25, 2023 20:51
@rafmudaf rafmudaf merged commit 0d2bfec into NREL:develop Apr 25, 2023
@RHammond2 RHammond2 deleted the bug_fix/missing_f branch May 8, 2023 15:52
@rafmudaf rafmudaf mentioned this pull request May 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafmudaf rafmudaf rafmudaf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@RHammond2 @rafmudaf