FLORIS Tools API improvements #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafmudaf
added
enhancement
This means users don’t have to also import matplotlib.pyplot as plt only to run plt.show()
Also replaces another method CutPlane.subtract to do something similar. That one made assumptions about the order and expected operations. The new subtract method expects all preprocessing to be down outside of the class.
In subsequent function calls, the yaw angles are not reset when they are all zeros. This means that if initially the yaw angles are non-zero and then they’re all-zero, the non-zero yaw settings are retained.
rafmudaf
force-pushed
the
api
branch
2 times, most recently
from
f03e7e0
to
95e3eec
Compare
paulf81
approved these changes
Nov 14, 2022
And clean up examples imports
minSpeed, maxSpeed => min_speed, max_speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull request adds some consistency to a few areas of the
floris.toolspackage. Some changes are minor bug fixes, but most are simply, in my opinion, improvements to the API's.There is one major bug fix:
floris_interface.calculate_wakewas incorrectly handling non-zero yaw angles. In subsequent function calls, all-zero yaw angles were ignored, so if prior function calls had non-zero yaw settings those would be retained.Related issue, if one exists
Fixes #443
Fixes #451
Impacted areas of the software
Tools
Test results, if applicable
I've also added a test to check the yaw angle setting / resetting in
floris_interface.