adding missing time_series flag to cc flow field solver call #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulf81
approved these changes
Sep 1, 2022
|
@bayc Could you add the API documentation for the Grid class time_series argument here: https://github.com/bayc/floris/blob/2bb8a15daa068668d7cf06cf934f458a586ee985/floris/simulation/grid.py#L57? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This is a small bugfix to add a missing
time_seriesflag to the CC model full flow field solver. It is pointed at the develop branch as the time series functionality is not yet in the main branch.Related issue, if one exists
None.
Impacted areas of the software
solver.pyAdditional supporting information
None.
Test results, if applicable
Can now run example 02 and visualize the CC model, when previously it would error out.