Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented and legacy code in floris_interface.py #397

Merged
merged 5 commits into from
May 26, 2022

Conversation

Bartdoekemeijer
Copy link
Collaborator

@Bartdoekemeijer Bartdoekemeijer commented Mar 18, 2022

Status
This PR is ready to be merged.

Feature or improvement description
floris_interface.py contains much code that is either commented out or no longer used. I'd like to clean this up for clarity. I have removed remnants from the uncertainty features but there's much more code that's commented out. I figured I would open a PR to tackle that.

Related issue, if one exists
N/A.

Impacted areas of the software
N/A.

Additional supporting information
N/A.

Test results, if applicable
N/A.

@Bartdoekemeijer Bartdoekemeijer added enhancement An improvement of an existing feature v3 Label to denote focus on v3 labels Mar 18, 2022
@rafmudaf rafmudaf marked this pull request as draft March 18, 2022 17:46
@rafmudaf
Copy link
Collaborator

@Bartdoekemeijer I've converted this pull request to draft, so just hit the "Ready for review" button when it's ready to roll

@Bartdoekemeijer
Copy link
Collaborator Author

I removed all uncertainty-related remnant code in FlorisInterface since that has now become part of UncertaintyInterface. I also removed a couple of other functions that I think are safe to be removed. @bayc and @rafmudaf could you check floris_interface.py and remove any other code that you think should be removed?

@rafmudaf rafmudaf marked this pull request as ready for review May 26, 2022 20:36
@rafmudaf rafmudaf merged commit 1d094cd into NREL:develop May 26, 2022
@Bartdoekemeijer Bartdoekemeijer deleted the bug_fix/cleanup_fi branch May 26, 2022 20:55
@rafmudaf rafmudaf mentioned this pull request Sep 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature v3 Label to denote focus on v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants