Fix for repeated calls to calculate_wake returning incorrect values. #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to be merged
Feature or improvement description
This bugfix adds
_sorted
versions of the respective variables that get sorted based on wind direction during the initialization step for use within the solver. In the finalize step after the solve completes, the sorted variables are unsorted and stored in a new variable, therefore allowing repeated calls tocalculate_wake
and maintaining the sorting of the required variables.Related issue, if one exists
Closes #378
Impacted areas of the software
Most of the simulation software, though I am not 100% that I have properly covered all the initialization of the variables (@rafmudaf could use your eyes here).
Additional supporting information
The code in issue #378 now produces the expected result of: