Add and rearange initial example #322
Conversation
…o feature/add_streamlit
paulf81
added
enhancement
|
It's great that there's a notebook explaining things slowly and showing the value of variables. Excellent idea @paulf81. On that notebook, my only feedback is that the tools API will certainly change over the next few days so we'll have to be sure to update the example and explanations. |
|
Sounds good, I think that is my expectation, but still valuable to explain how things work at the present moment and then update as we go. |
I'm in the process of redeveloping the |
|
hi @bayc and @rafmudaf I went through all the examples after merging in the latest v3, and updated the visualization methods to the new standards/function name and confirm each example works. I think this doing a better and better job of introducing the key concepts in an incremental way, but will be curious what you (and also @Bartdoekemeijer ) think |
examples/03_making_adjustments.py
Outdated
| "flow_field_grid_points": [200,100,7] | ||
| } | ||
| fi.reinitialize(solver_settings=solver_settings) | ||
| # # Configure this simulation for visualization using the full flow field grid |
There was a problem hiding this comment.
Should this just be removed? Is it not needed anymore?
examples/12_streamlit_demo.py
Outdated
| # print(farm_power_results) | ||
|
|
||
| # # Show the farm results | ||
| # df_farm = pd.DataFrame.from_records(farm_power_results, columns = ['model','yaw','power']).set_index(['yaw','model']).unstack() |
There was a problem hiding this comment.
Should this code be removed?
examples/12_streamlit_demo.py
Outdated
| st.header("Power Comparison") | ||
| st.write(fig_turb_pow) | ||
|
|
||
| # print(farm_power_results) |
examples/12_streamlit_demo.py
Outdated
| @@ -0,0 +1,176 @@ | |||
| # Copyright 2021 NREL | |||
There was a problem hiding this comment.
Should this be renamed to example 11?
There was a problem hiding this comment.
or we can save 11 for a mulit turbine example?
# Conflicts: # examples/03_making_adjustments.py
This pull requests combines former branches which added new initial examples, as well as interactive streamlit demonstrations.
Finally pull requests adds a new notebook which maybe could provide a first overview in critical syntax and how some things are importantly changed from v2 and v3
This pull request also seeks to address issue #318 and issue #315 by providing clearer demonstration of recommended use via the above notebook.
Not yet, still some discussion
Feature or improvement description
Adds four additional examples:
examples/__getting_started.ipynb
examples/00_getting_started.py
examples/12_streamlit_demo.py
examples/13_streamlit_demo_large_farm.py
However the main idea is to agree on the syntax rules laid out in the notebook, then all following examples will be updated
Related issue, if one exists
issue #318
issue #315
issue #345