Skip to content

Commit

Permalink
Fix the deployment infrastructure (#343)
Browse files Browse the repository at this point in the history
* Move version file into the src dir

* Fix setuptools package search

* Update version to 3.0rc4

* Move floris package to root

* Update pull request template
  • Loading branch information
rafmudaf authored Feb 27, 2022
1 parent 98280f1 commit ea75bf1
Show file tree
Hide file tree
Showing 77 changed files with 25 additions and 21 deletions.
24 changes: 17 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,28 @@

**Complete this sentence**
THIS PULL REQUEST __ [IS/IS NOT] __ READY TO MERGE
<!-- Is this pull request ready to be merged? -->
<!-- i.e. tests pass or are expected to fail; all development is finished; appropriate documentation is included. -->
<!-- If not but opening the pull request will facilitate development, make it a "draft" pull request -->

**Feature or improvement description**
<A clear and concise description of the new code.>
<!-- A clear and concise description of the new code. -->

**Related issue, if one exists**
<Link to a related GitHub Issue.>
<!-- Link to a related GitHub Issue. -->

**Impacted areas of the software**
<List areas which should be impacted by this pull request. This helps to determine the verification tests.>
<!-- List any modules or other areas which should be impacted by this pull request. This helps to determine the verification tests. -->

**Additional supporting information**
<Add any other context about the problem here.>
<!-- Add any other context about the problem here. -->

**Test results, if applicable**
<Add the results from unit tests and regression tests here along with justification for any failing test cases.>
<!-- Add the results from unit tests and regression tests here along with justification for any failing test cases. -->

<!-- Release checklist:
- Update the version in
- [ ] README.rst
- [ ] docs/index.rst
- [ ] floris/VERSION
- [ ] Verify readthedocs builds correctly
- [ ] Create a tag in the NREL/FLORIS repository
-->
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ and importing FLORIS:
3.0rc2

FILE
~/floris/src/floris/__init__.py
~/floris/floris/__init__.py
```

It is important to regularly check for new updates and releases as new
Expand Down
1 change: 0 additions & 1 deletion VERSION

This file was deleted.

2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ and importing FLORIS:
3.0rc2

FILE
~/floris/src/floris/__init__.py
~/floris/floris/__init__.py
```

It is important to regularly check for new updates and releases as new
Expand Down
1 change: 1 addition & 0 deletions floris/VERSION
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3.0rc4
2 changes: 1 addition & 1 deletion src/floris/__init__.py → floris/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@

from pathlib import Path

with open(Path(__file__).parent.parent.parent / "VERSION") as _version_file:
with open(Path(__file__).parent / "VERSION") as _version_file:
__version__ = _version_file.read().strip()
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ known_third_party = [
"scipy",
"attr"
]
known_first_party = ["floris", "src"]
known_first_party = ["floris"]
combine_as_imports = true
force_grid_wrap = 0
include_trailing_comma = true
Expand Down
12 changes: 3 additions & 9 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,7 @@
# See https://floris.readthedocs.io for documentation


# Note: To use the 'upload' functionality of this file, you must:
# $ pip install twine

import io
import os
from pathlib import Path

from setuptools import setup, find_packages


Expand Down Expand Up @@ -56,7 +50,7 @@
}

ROOT = Path(__file__).parent
with open(ROOT / "VERSION") as version_file:
with open(ROOT / "floris" / "VERSION") as version_file:
VERSION = version_file.read().strip()

setup(
Expand All @@ -69,8 +63,8 @@
author_email=EMAIL,
python_requires=REQUIRES_PYTHON,
url=URL,
package_dir={"": "src"},
packages=find_packages(where="src"),
packages=find_packages(exclude=["tests", "*.tests", "*.tests.*", "tests.*"]),
package_data={'floris': ['VERSION']},
install_requires=REQUIRED,
extras_require=EXTRAS,
include_package_data=True,
Expand Down

0 comments on commit ea75bf1

Please sign in to comment.