-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix stuck sensor detection only applying to last column #177
[BUGFIX] Fix stuck sensor detection only applying to last column #177
Conversation
e4c9e14
to
e319a1f
Compare
Two of the examples (that I'm aware of) use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good @misi9170, and thank you for adding the tests
Thanks @paulf81 . I realized I hadn't pushed the changes to the examples (not to the running code, just to the notebook output), so I'll do that now and then merge. |
Addresses issue raised in #175.
The stuck sensor indices were only being returned for the last column checked, as opposed to a union of the indices over all columns. This PR addresses that issue.
To do
False
, which whenTrue
will instead return a dictionary containing a numpy array of stuck sensor indices for each column passed.@DanielKerrigan 's script below now produces the expected results