Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5223 - update conan ruby to relax MSC_VER restriction #5224

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 17, 2024

Pull request overview

Note: the macos apple-clang-14 armv8 builds failed (the apple-clang-15 worked), and I don't understand why (what changed? Probably just from the GHA runners themselves...)... So maybe we'll need to figure that out later if we get people using apple-clang14 and not 15 that complain they can't build https://github.com/jmarrec/conan-recipes/actions/runs/9545192414/job/26305457773

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

Note: the armv8 macos14 builds failed, and I don't understand why... So maybe we'll need to figure that out...
@jmarrec jmarrec self-assigned this Jun 17, 2024
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Jun 17, 2024
@jmarrec
Copy link
Collaborator Author

jmarrec commented Sep 13, 2024

I hit this today again with MSVC > 1940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Conan Dependency / Package manager problems component - Ruby bindings Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan ruby: Windows build no longer works on Windows2022 github runner
2 participants