Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] Update pip package to fix projection issue #488

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

nickchadwick-noaa
Copy link
Collaborator

Updated Pipfile to use a specific version of pyproj as the newer version of pyproj was throwing projection issues in the synthesize_test_cases.py script.

This shows no changes on the hydrological outputs of fim_run.

Docker image foss-fim:dev_pyproj_downgrade has been created for testing purposes for the different pyproj version in this PR.

Addresses issue #483

@nickchadwick-noaa nickchadwick-noaa added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 29, 2021
@nickchadwick-noaa nickchadwick-noaa added this to the FIM v3.X milestone Nov 29, 2021
@nickchadwick-noaa nickchadwick-noaa self-assigned this Nov 29, 2021
@BradfordBates-NOAA BradfordBates-NOAA merged commit 3dabefc into dev Nov 29, 2021
@BradfordBates-NOAA BradfordBates-NOAA deleted the dev-pip-packages-update branch November 29, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5pt] Compare Docker Image versions for possible Python package versioning issues
2 participants