-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pydocstyle #208
Fix pydocstyle #208
Conversation
Thanks @Radonirinaunimi, it's an annoying task, but useful. However, since part of the task really consists in reviewing the docstrings, I would suggest you not to target (necessarily) completion. Even reducing the amount of errors might be enough, and a significant improvement. |
Yes, indeed! That'd be exactly the plan. |
@Radonirinaunimi do you want to merge what is already here? just to not loose it? and convert the list into an issue? |
My personal goal is to finish this before the Yadism paper appear. If that is not achieved, I agree that we can merge already what is here. But I haven't said my last words yet 😄 |
better push for the paper itself 😇 or if you want to code, go for benchmarks |
Absolutely! But this, if it will happen, will be for the outside hours. |
It was strongly advised before to fix the pydocstyle in the same way as what was done in NNPDF/eko#243 and hence the reason for this PR. I volunteered to do so and will do it incrementally, but everyone is invited to contribute.