Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generators for nDIS processes #160

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

Radonirinaunimi
Copy link
Member

@Radonirinaunimi Radonirinaunimi commented Nov 30, 2022

The following implements and tracks the observable.yaml generators for both the NC & CC nDIS processes included in the nuclear PDF fits (taking into account the displaced $b$-threhsold). The computation of the corresponding pineapplgrids will be tracked in https://github.com/NNPDF/fktables/issues/34 while the overall status of the benchmarking comparisons will be tracked in NNPDF/pinecards#162.

CC Datasets:

Dataset name Observable.Yaml Comments
NMC_p_D ☑️ -
SLAC_D ☑️ -
BCDMS_D ☑️ -
SLACE139_He_D ☑️ -
NMC95RE_He_D ☑️
NMC95_Li_D ☑️
SLACE139_Be_D ☑️ -
NMC96_Be_C ☑️
EMC90_C_D ☑️
SLACE139_C_D ☑️ -
NMC95_C_D ☑️
FNALE665_C_D ☑️
NMC95RE_C_Li ☑️
BCDMS85_N_D ☑️
SLACE139_Al_D ☑️ -
NMC96_Al_C ☑️
SLACE139_Ca_D ☑️
NMC95RE_Ca_D ☑️
EMC90_Ca_D ☑️
FNALE665_Ca_D ☑️
NMC95RE_Ca_Li ☑️
NMC96_Ca_C ☑️
EMC97_Fe_D ☑️
SLACE139_Fe_D ☑️ -
NMC96_Fe_C ☑️
BCDMS85_Fe_D ☑️
EMC88_Cu_D, EMC93_Cu_D ☑️
SLACE139_Ag_D ☑️ -
EMC88_Sn_D ☑️
NMC96_Sn_C ☑️
FNALE665_Xe_D ☑️
SLACE139_Au_D ☑️ -
FNALE665_Pb_D ☑️
NMC96_Pb_C ☑️

CC Datasets:

Dataset name Observable.Yaml Comments
CHORUS_NU_Pb ☑️ -
CHORUS_NB_Pb ☑️
NUTEV_NU_Fe ☑️
NUTEV_NB_Fe ☑️ -

PS: After some thinking, I believe that this is currently the best place to generate these observable.yaml as the changes required wrt to the already existing datasets are minimal.

@Radonirinaunimi Radonirinaunimi self-assigned this Nov 30, 2022
@felixhekhorn felixhekhorn added enhancement New feature or request physics physics features labels Dec 5, 2022
@felixhekhorn
Copy link
Contributor

Remember to run pre-commit at some point (you may only ignore pydocstyle 🙃 )

@felixhekhorn
Copy link
Contributor

Maybe you want to have #199 in? (that's why I just merged it)

@Radonirinaunimi
Copy link
Member Author

Remember to run pre-commit at some point (you may only ignore pydocstyle upside_down_face )

Done 😃

Maybe you want to have #199 in? (that's why I just merged it)

Thanks! Just merged it.

This is also ready to be reviewed/merged.

@Radonirinaunimi Radonirinaunimi changed the title Implement generators for NC nDIS processes Implement generators for nDIS processes Jun 23, 2023
CHORUS_CC_NU_PB_SIGMARED:
description: CHORUS reduced cross section neutrino-nucleon scattering on lead
nnpdf_id: CHORUSNUPb

CHORUS_NU_PB:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you need a copy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(similar for others)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to make sure that the grids are generated assuming $ep$. If we'd fit the bound nucleus PDF instead (which is what we should do in the future) then they will be same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it then not be called EL_P or similar?

description: BCDMS NC nuclear data
nnpdf_id: BCDMS85FeD
y_label: F2p
y_label_tex: $F_{2,\mathrm{tot}}^{(\mathrm{p})}$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you want to reflect more information here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(similar for others)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this along with the references below, are still something I have to properly add later (during some free time 🙃 ).

Comment on lines +1 to +3

arxiv: null
hepdata: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
arxiv: null
hepdata: null
arxiv: null
hepdata: null

are there no references?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(similar for others)

@giacomomagni giacomomagni added datatoolchain observable card generator and removed physics physics features labels May 1, 2024
@giacomomagni giacomomagni marked this pull request as draft August 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datatoolchain observable card generator enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants