Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bugged raise Error when using multiple covmats #1951

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Remove bugged raise Error when using multiple covmats #1951

merged 4 commits into from
Feb 21, 2024

Conversation

RoyStegeman
Copy link
Member

No description provided.

@RoyStegeman RoyStegeman added the bug Something isn't working label Feb 20, 2024
@scarlehoff
Copy link
Member

I will continue complaining about the total covmat for my entire life. You cannot stop me.

@RoyStegeman RoyStegeman changed the title Stop complaining about total covmat Don't raise unnecessary error when using multiple covmats Feb 20, 2024
@RoyStegeman
Copy link
Member Author

Counteroffer: please at least don't raise unnecessary errors anymore

@scarlehoff
Copy link
Member

I was seriously thinking about adding raise Exception everywhere inside the plotoptions module and then going on a long vacation immediately after.

@RoyStegeman RoyStegeman changed the title Don't raise unnecessary error when using multiple covmats Remove bugged raise Error when using multiple covmats Feb 21, 2024
scarlehoff
scarlehoff approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@RoyStegeman RoyStegeman merged commit dbedd5b into master Feb 21, 2024
8 checks passed
@RoyStegeman RoyStegeman deleted the fix_total_covmat branch February 21, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarlehoff scarlehoff scarlehoff approved these changes

@andreab1997 andreab1997 Awaiting requested review from andreab1997

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyStegeman @scarlehoff @andreab1997