Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttb dataset fixes #1947

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Ttb dataset fixes #1947

merged 4 commits into from
Feb 19, 2024

Conversation

t7phy
Copy link
Member

@t7phy t7phy commented Feb 18, 2024

No description provided.

@scarlehoff
Copy link
Member

I cannot find some of the fktables reference in this PR in theory 600, maybe you forgot to update it? Or is it not ready yet? (if so we can wait to merge)

@t7phy
Copy link
Member Author

t7phy commented Feb 19, 2024

No no, it's fully ready. Just that I haven't copied the fktables to cern server, which I plan to do later today. This can and should be merged.

@scarlehoff
Copy link
Member

Then let me know when the fktables are ready so that I can test and merge.

@t7phy
Copy link
Member Author

t7phy commented Feb 19, 2024

but it's already tested for them all, the report for new ones is here for example: https://vp.nnpdf.science/_ay4TCZWTOW3NlufWTfrVQ==

@scarlehoff
Copy link
Member

You should add these reports to the PRs when you have them! I cannot know that it's done otherwise (and in this case I already have a runcard for that, otherwise I would've asked you for it :P)

In any case, let me know when you copy the fktables.

@t7phy
Copy link
Member Author

t7phy commented Feb 19, 2024

fktables are in theory 600 now

@scarlehoff
Copy link
Member

thanks

@scarlehoff scarlehoff merged commit f9e8c4b into master Feb 19, 2024
10 checks passed
@scarlehoff scarlehoff deleted the ttb-fixes branch February 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants