Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from defaults to forge, update workflows #1932

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

scarlehoff
Copy link
Member

No description provided.

@APJansen
Copy link
Collaborator

APJansen commented Feb 6, 2024

Are all those other pins still necessary after downgrading conda-build?

@scarlehoff
Copy link
Member Author

Let me revert some of them, if they happen to be we keep them and merge this.

Comment on lines +30 to +32
with:
fetch-tags: true
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can probably get away with something better than 0, but just fetch-tag doesn't do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? Don't we only need the last commit, which is the default behaviour?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but it was one of the problem here #1928
(and with fetch-depth: 0 we recover the behaviour of version 1 in that sense)

Note that we use the tag but also the number of commits with respect to the tag. It might be enough with getting out the commit of the tag? I don't know...

@scarlehoff
Copy link
Member Author

Removing pins and trying to use conda-forge didn't work for mac. My appetite for testing is finished now.

@scarlehoff scarlehoff merged commit e4a1992 into master Feb 6, 2024
16 checks passed
@scarlehoff scarlehoff deleted the test_only_forge branch February 6, 2024 12:46
@APJansen APJansen mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants