-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from defaults to forge, update workflows #1932
Conversation
Are all those other pins still necessary after downgrading conda-build? |
Let me revert some of them, if they happen to be we keep them and merge this. |
with: | ||
fetch-tags: true | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We can probably get away with something better than 0, but just fetch-tag doesn't do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? Don't we only need the last commit, which is the default behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but it was one of the problem here #1928
(and with fetch-depth: 0
we recover the behaviour of version 1 in that sense)
Note that we use the tag but also the number of commits with respect to the tag. It might be enough with getting out the commit of the tag? I don't know...
f86fa3a
to
c962355
Compare
Removing pins and trying to use conda-forge didn't work for mac. My appetite for testing is finished now. |
No description provided.