Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset/prediction ordering problem in theory covmat creation #1899

Merged
merged 14 commits into from
Dec 21, 2023
Merged

Fix dataset/prediction ordering problem in theory covmat creation #1899

merged 14 commits into from
Dec 21, 2023

Conversation

RoyStegeman
Copy link
Member

@RoyStegeman RoyStegeman commented Dec 19, 2023 •
edited
Loading

we should probably use reindex in most (all?) places where multiple dataframes with the same labels in the index are being loaded.

@RoyStegeman RoyStegeman added the bug Something isn't working label Dec 19, 2023
andreab1997
andreab1997 reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment I only had a quick look, I will have a more careful look later

validphys2/src/validphys/theorycovariance/construction.py Outdated Show resolved Hide resolved
validphys2/src/validphys/theorycovariance/construction.py Outdated Show resolved Hide resolved
@RoyStegeman RoyStegeman changed the title Fix thcovmat creation Fix dataset/prediction ordering problem in theory covmat creation Dec 20, 2023
@scarlehoff scarlehoff merged commit 96e0fc5 into master Dec 21, 2023
6 checks passed
@scarlehoff scarlehoff deleted the fix_thcovmat_creation branch December 21, 2023 09:47
@andreab1997 andreab1997 mentioned this pull request Dec 21, 2023
Merged
@scarlehoff scarlehoff mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreab1997 andreab1997 andreab1997 left review comments

@scarlehoff scarlehoff scarlehoff approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyStegeman @scarlehoff @andreab1997