Raise an exception when use_pdferr is used together with plot_fancy #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think these diffs are due to my own change: ccf3c62 Though there are also a lot of other changes, so maybe it was indeed missed :) |
RoyStegeman
reviewed
Nov 14, 2023
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
RoyStegeman
approved these changes
Nov 14, 2023
scarlehoff
deleted the
raise_and_exception_with_plot_fancy_and_pdferr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1843
I'm just adding a check to
plot_fancy. I've taken the liberty to also runblacksince apparently it was missing fromdataplots.py?The only change that is not from black is in line 397 (sorry @RoyStegeman, I must've somehow missed
dataplots.pywhen I passed black to every file...)