Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolven3fit new w eko 0.13 #1742

Merged
merged 7 commits into from
May 26, 2023
Merged

Evolven3fit new w eko 0.13 #1742

merged 7 commits into from
May 26, 2023

Conversation

giacomomagni
Copy link
Contributor

This PR is to update evolven3fi_new to eko==0.13.2

@scarlehoff
Copy link
Member

Thanks, the test won't work since I need to fix the conda package for that.

Is the code working for you locally? If so I'll try to fix the conda package in the next few hours.

@giacomomagni
Copy link
Contributor Author

Is the code working for you locally? If so I'll try to fix the conda package in the next few hours.

Yes tests are passing and I was able to generate an eko. Haven't check the loading yet.

conda-recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@andreab1997 andreab1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me

@andreab1997
Copy link
Contributor

Just to be sure: about the usual matter of squaring the AlphaQs, it should be fixed in eko (meaning that the info file should be already come correct from the eko function) now so we should not need anymore the sqrt here. Can you check this?

@scarlehoff
Copy link
Member

I checked explicitly that info["AlphaS_Q"] is not squared.

I've also tested that I can produce an eko (for theory 399 though, so very small) and evolve a PDF loading said eko (again, theory 399 and only one replica).

Once the test are done I think this can be merged.

Co-authored-by: Giacomo Magni <39065935+giacomomagni@users.noreply.github.com>
@scarlehoff scarlehoff merged commit 84c26d5 into master May 26, 2023
@scarlehoff scarlehoff deleted the evoln3fit_w_eko_0.13 branch May 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants