-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evolven3fit new w eko 0.13 #1742
Conversation
Thanks, the test won't work since I need to fix the conda package for that. Is the code working for you locally? If so I'll try to fix the conda package in the next few hours. |
Yes tests are passing and I was able to generate an eko. Haven't check the loading yet. |
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good to me
Just to be sure: about the usual matter of squaring the |
I checked explicitly that I've also tested that I can produce an eko (for theory 399 though, so very small) and evolve a PDF loading said eko (again, theory 399 and only one replica). Once the test are done I think this can be merged. |
Co-authored-by: Giacomo Magni <39065935+giacomomagni@users.noreply.github.com>
This PR is to update evolven3fi_new to
eko==0.13.2