multiclosure internal dataset loader should use t0_covmat_from_systematics #1719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in the current implementation. The
internal_multiclosure_dataset_loader
function should take the t0 covmat from a single dataset rather than from data. In the previous implementation collect commands like the following were crushing because of shape incompatibility since t0 covmat was being constructed for the whole list of DataSetSpec's .datasets_expected_bias_variance = collect( "expected_dataset_bias_variance", ("data",))