add use_scalevar_uncertainties to loading custom comvat docs #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreab1997
requested changes
Apr 4, 2023
RoyStegeman
commented
Apr 4, 2023
andreab1997
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different from what we originally said, there are different ways of combining custom covmats and covmats that are generated from pointprescirption instructions in the runcards and it's not either one or the other. The implementation of scalevariations is in general a bit messy so we may want to improve that, but it's not a priority right now so hopefully we can fix that at some point 🤞.
Having said that - this bit of the docs was still outdated.