Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replica selector functionality #1703

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Remove replica selector functionality #1703

merged 1 commit into from
Mar 23, 2023

Conversation

Zaharid
Copy link
Contributor

@Zaharid Zaharid commented Mar 22, 2023

This was a long forgotten experiment. I thought it was a good idea, but nobody is going to work on it now. The replica plots in there had been broken for a while and nobody had noticed.

This was a long forgotten experiment. I thought it was a good idea, but
nobody is going to work on it now. The replica plots in there had been
broken for a while and nobody had noticed.
@Zaharid Zaharid requested a review from scarlehoff March 22, 2023 14:54
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use black so what is left in the file is standardized it might be a good moment. Otherwise lgtm.

@Zaharid Zaharid merged commit 0c1bf0b into master Mar 23, 2023
@Zaharid Zaharid deleted the noreplicaselector branch March 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants