Separate xgrid and model generation within model trainer #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaharid
reviewed
Dec 6, 2022
Zaharid
reviewed
Dec 6, 2022
Zaharid
reviewed
Dec 6, 2022
Co-authored-by: Zaharid <zk261@cam.ac.uk>
|
Should this be cheched by the fitbot? |
|
It is actually just a reordering of the code with absolutely no changes, but it is "free" so... why not. |
|
LGTM. |
|
Seems fine to me as well. Let's wait for the bot and then merge |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
RoyStegeman
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the xgrid that is used as input for the PDF (which is a concatenation of all the points in x the fktables ask for) was being prepared just before the observable generation.
There was no reason for that, it just happened to be there. For #1622 we need to generate the photon in all those
x-points. While technically it doesn't matter where luxqed is called, I think it is better to call it from the top(est?) possible level. In this case, just after the grid of x-points is prepared.