Add t0 chi2 to comparefitsreport #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaharid
reviewed
Oct 7, 2022
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
|
I'm going to be picky and say that it should be either part of the summary table or completely separated, with its own heading. |
|
A single table would of course be the obvious way to format it, but since the t0 settings would be different between entries reportengine cannot take care of it. So either we do this, or we just calculate the different t0 settings inside one of the summary functions out of reach from reportengine (but this seems pretty ugly/bad practice). But sine you're not alone with this opinion #1613 (comment) I guess I'l place another heading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during the meeting today, we should have the t0 chi2 info by default included in the fitreports.