Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing T24 and V24 definition in vp #1445

Merged
merged 3 commits into from
Oct 28, 2021
Merged

fixing T24 and V24 definition in vp #1445

merged 3 commits into from
Oct 28, 2021

Conversation

tgiani
Copy link
Contributor

@tgiani tgiani commented Oct 27, 2021 •
edited by Zaharid
Loading

this should fix the definition of T24 and V24

Closes #1444.

@tgiani tgiani mentioned this pull request Oct 27, 2021
Closed
@Zaharid
Copy link
Contributor

Zaharid commented Oct 27, 2021

Please add a reference where these definitions can be founds.

@tgiani
Copy link
Contributor Author

tgiani commented Oct 27, 2021

see for example eqs 56, 57 https://arxiv.org/pdf/0808.1231.pdf

@Zaharid
Copy link
Contributor

Zaharid commented Oct 27, 2021

I meant please add that as a comment :)

@Zaharid
Change space
f91d114 
To keep alignment consistent.
@Zaharid Zaharid merged commit 817f9aa into master Oct 28, 2021
@Zaharid Zaharid deleted the TV24bug branch October 28, 2021 07:42
@Zaharid Zaharid added the bug Something isn't working label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaharid Zaharid Zaharid approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

T24 and V24 lack of contribution of charm
2 participants
@tgiani @Zaharid