Add sysroot to installation instruction #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyStegeman
reviewed
Sep 2, 2021
There was a problem hiding this comment.
The problem is not that sysroot is not installed at all, rather that after installing the nnpdf dependencies the default version is 2.12. See also,
Lines 15 to 16 in aaaf70f
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
RoyStegeman
approved these changes
Sep 2, 2021
scarlehoff
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
But the real fix is #1284 (also because relying on inifinite free CI time might not be so sustainable).
I agree.
Edit: also, maintaining a requeriments.txt file for an easy conda-less installation could be good as well, even as an unsupported feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a built dependency since #1280 and we can't seem to get rid of it. People are finding (see #1290) that following the current instructions gives errors so we should add it until we can remove it.
Closes #1290.