Fix some problems in spider plots #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't actually tested this, so it would be good if someone could check that the various options still work. |
Closed
| phi = [exp_phi for (exp_phi, npoints) in fitphi] | ||
| xticks = [group.name for group in fitgroup] | ||
| for fit, fitphi, fitgroup in zip(fits, fits_groups_data_phi, fits_groups_data): | ||
| phi = [exp_phi for (exp_phi, npoints) in fitphi] |
There was a problem hiding this comment.
I've tested this and it works fine. The tiny suggestion below just gets rid of an unused variable:
Suggested change
| phi = [exp_phi for (exp_phi, npoints) in fitphi] | |
| phi = [exp_phi for (exp_phi, _) in fitphi] |
and (in terms of spider plots) there is one more here:
nnpdf/validphys2/src/validphys/dataplots.py
Line 622 in 1e8ffd9
There were some unused variables, a typo in a comparison and bad indentation on various plots.
Zaharid
force-pushed
the
spiderfixes
branch
from
1e8ffd9
to
d5e165c
Compare
Zaharid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some unused variables, a typo in a comparison and bad
indentation on various plots.