Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable self-hosted runner for fit-bot #1369

Merged
merged 10 commits into from
Aug 26, 2021
Merged

disable self-hosted runner for fit-bot #1369

merged 10 commits into from
Aug 26, 2021

Conversation

scarrazza
Copy link
Member

Needs testing.

@scarrazza scarrazza added the run-fit-bot Starts fit bot from a PR. label Aug 24, 2021
@scarlehoff
Copy link
Member

Two questions:

  1. Should we need a netrc file for this action? (all dependencies of the nnpdf package should be public a not coming from conda-private, right?)
  2. I see the secret was updated yesterday, but it looks that's the problem?

@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
@scarrazza
Copy link
Member Author

This seems to work, but postfit is taking ages and we hit the walltime...

@scarlehoff
Copy link
Member

Is it postfit or the upload that failed?

@scarrazza
Copy link
Member Author

scarrazza commented Aug 25, 2021

Looks like vp-upload, obviously, does not have a proper ssh key stored in the server. Usually we use echo "$NNPDF_SSH_KEY" | base64 --decode > "$KEY" followed by scp -i $KEY but here with vp-upload this might be more tricky.

@scarlehoff
Copy link
Member

This should work with rsync https://github.com/shimataro/ssh-key-action

Co-authored-by: Juan M. Cruz-Martinez <juacrumar@lairen.eu>
@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
@scarrazza scarrazza added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 25, 2021
@scarrazza
Copy link
Member Author

From the CI log, I don't understand if is really vp-upload or something else that crashes. Any idea? Before doing a painful long debug?

@scarlehoff
Copy link
Member

Open a new PR with an action that does just the vp-upload.

@scarlehoff scarlehoff added run-fit-bot Starts fit bot from a PR. and removed run-fit-bot Starts fit bot from a PR. labels Aug 26, 2021
@github-actions
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff
Copy link
Member

Good bot. This can be merged.

@scarrazza
Copy link
Member Author

Thanks @scarlehoff, merging this now and removing the self-runner from the settings.

@scarrazza scarrazza merged commit b28a49b into master Aug 26, 2021
@scarrazza scarrazza deleted the fitbotnormal branch August 26, 2021 15:53
@Zaharid Zaharid added the devtools Build, automation and workflow label Oct 28, 2021
@github-actions
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff
Copy link
Member

TIL all labels get passed down to the actions whenever one is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools Build, automation and workflow run-fit-bot Starts fit bot from a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants