Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta chi2 table by group #1329

Merged
merged 7 commits into from
Apr 6, 2022
Merged

Delta chi2 table by group #1329

merged 7 commits into from
Apr 6, 2022

Conversation

wilsonmr
Copy link
Contributor

So I think due to the timing of when #1151 got merged, something broke and it's to do with collecting data over fits with use_fitcommondata True. For some reason it doesn't get properly resolved and all the commondata files point at those from the first fit. I think it's because we now implicitly parse the datasets from the outer namespace and for some reason this caches the first result somewhere, I guess it's because produce_data doesn't set fit in the context when parsing the individual datasets but I'm not really sure.

After a long time if messing around with this I got rid of the old functions which largely were uninteresting and unused and just fixed delta chi2 table which is what we show in the paper. Adding the ability to use an arbitrary grouping turned out to be a lot more effort than I thought (and probably than it's worth but there we go..)

There is some annoying internals here which really ought to be fixed. Now that we can used python commondata we should really use it to generate the level 1 data and then save it in a sensible format so this isn't required.

Anyway, you can now group by either process or experiment: https://vp.nnpdf.science/XbuRheXoRU60J_C68x3hyg==

@tgiani I'll hand this over to you, but I realise you've got a lot of closure related PRs now so you might want to delegate some tasks.

@tgiani tgiani self-assigned this Nov 17, 2021
@tgiani tgiani merged commit 6199574 into more-closure-plots Apr 6, 2022
@tgiani tgiani deleted the delta-chi2-table branch April 6, 2022 13:46
@Zaharid Zaharid added the enhancement New feature or request label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants