Add metadata groups to closure tables #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgiani can this be merged? |
|
I still have to review this, will do after I m done with the ct paper |
tgiani
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without spending more time on this, this was the best I could do. There seems to be a fair amount of redundancy but I think there isn't a better way to do it without getting rid of backwards compat.
Example report: https://vp.nnpdf.science/6oHHKWGkSw-d-LxFX59Fig==
the groups are much smaller so there are bigger fluctuations. The worst one is probably jets which actually has a fair amount of data. Anyway people asked for it, so here it is.