Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vp-comparefits requires a number of arguments to be added when ran from command-line, however the
--help
doesn't really help on knowing which they are. I've grouped them so that one can quickly know which are mandatory:Then there're the flags
th_covmat_if_present
andno-thcovmat_if_present
which are both the same one. I guess there might be a good reason why having one of the two was made mandatory but I think it makes more sense to befalse
by default and use it if needed? I've put as reviewer people who modified this file just in case I broke something important...Note: I've separated the thcovmat and the groupping commits so I can revert the thcovmat if there's a good reason for making it mandatory.