-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making n3fit use python pseudodata #1268
Conversation
Nice! We also want to be able to make closure data so I think the |
Actually wait, I think because the EDIT: opened an issue where I will test this #1269 |
Do we still want this seed logic: nnpdf/validphys2/src/validphys/n3fit_data.py Line 192 in 2d49938
|
@siranipour probably we can do something simpler.
|
The Also, any changes to the seed logic I would prefer it if they are done in separate PRs since they will also need to change all regression tests + fit bot, etc |
Yeah it can, I had just left it for now in case we wanted to use the old behaviour at any point |
I'm beginning to think the changes you mention here need to be done in this PR since the pseudodata generation does not replicate precisely the C++ pseudodata. I believe this is why the linux tests are failing currently |
Oh. Didn't realise that. In that case yes, do the changes here. Leave just the bot for another PR (or for the very last commit) so that we have the report of this PR vs master. |
@scarlehoff is there any neat way of generating the |
Nop, you have to do it manually. |
d4b10e8
to
1790552
Compare
1790552
to
3b9aacf
Compare
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
@scarlehoff the bot has been fixed in 0b21f84 so this can be merged if you're happy |
No description provided.