Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added layoutrenderer aspnet-request-has-posted-body and aspnet-request-stream-id #845

Merged
merged 20 commits into from
Aug 10, 2022

Conversation

bakgerman
Copy link
Contributor

There should not be any more unless .NET completely changes HttpContext in .NET 8
There were a few interfaces in Microsoft.AspNetCore.Connections.Features and Microsoft.AspNetCore.Http.Features to be added.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #845 (0993113) into master (8eac9d9) will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #845   +/-   ##
=====================================
+ Coverage      69%    71%   +1%     
=====================================
  Files          63     64    +1     
  Lines        1157   1187   +30     
  Branches      286    299   +13     
=====================================
+ Hits          804    837   +33     
+ Misses        229    214   -15     
- Partials      124    136   +12     
Impacted Files Coverage Δ
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 86% <0%> (-1%) ⬇️
src/NLog.Web/Internal/HostEnvironment.cs 0% <0%> (ø)
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs 53% <0%> (+53%) ⬆️
...d/LayoutRenderers/IISInstanceNameLayoutRenderer.cs 67% <0%> (+67%) ⬆️
...LayoutRenderers/AspNetWebRootPathLayoutRenderer.cs 67% <0%> (+67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Aug 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@snakefoot snakefoot changed the title Final Layout Render Additions Added layoutrenderer aspnet-request-has-body and aspnet-request-stream-id Aug 10, 2022
@snakefoot snakefoot merged commit f554128 into NLog:master Aug 10, 2022
@snakefoot snakefoot added this to the 5.1.1 milestone Aug 10, 2022
@bakgerman bakgerman deleted the aspnetcore-layout-renders branch August 10, 2022 15:07
@snakefoot
Copy link
Contributor

@snakefoot snakefoot changed the title Added layoutrenderer aspnet-request-has-body and aspnet-request-stream-id Added layoutrenderer aspnet-request-has-posted-body and aspnet-request-stream-id Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants