Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support ASP.NET Core 1 #683

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Drop support ASP.NET Core 1 #683

merged 1 commit into from
Aug 28, 2021

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Aug 28, 2021 •
edited
Loading

fixes #575

  • release 4.14 first

@304NotModified 304NotModified added this to the 5.0 milestone Aug 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021 •
edited
Loading

Codecov Report

Merging #683 (7621f53) into master (2162208) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #683   +/-   ##
=====================================
  Coverage      64%    64%           
=====================================
  Files          38     38           
  Lines         581    581           
  Branches      140    140           
=====================================
  Hits          371    371           
  Misses        157    157           
  Partials       53     53
Impacted Files Coverage Δ
src/Shared/Internal/HttpContextExtensions.cs 50% <ø> (ø)
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs 0% <ø> (ø)
.../Shared/LayoutRenderers/AspNetRequestPostedBody.cs 47% <ø> (ø)
...LayoutRenderers/AspNetWebRootPathLayoutRenderer.cs 0% <ø> (ø)
...d/LayoutRenderers/IISInstanceNameLayoutRenderer.cs 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2162208...7621f53. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit 8082244 into master Aug 28, 2021
@304NotModified 304NotModified deleted the drop-support-aspnetcore1 branch August 28, 2021 21:03
@snakefoot snakefoot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Drop support ASP.NET Core 1
2 participants
@304NotModified @codecov-commenter