Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

464-Optional code of conduct #530

Merged
merged 7 commits into from
Aug 23, 2024
Merged

464-Optional code of conduct #530

merged 7 commits into from
Aug 23, 2024

Conversation

lyashevska
Copy link
Member

@lyashevska lyashevska commented Aug 22, 2024

Description

Make code of conduct optional.

Related issues:

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Test 1:

Step-1:
Run the command below and say 'yes' to code of conduct question.

copier copy --vcs-ref 464-codeconduct https://github.com/nlesc/python-template test_yes

Step-2:
Run the command below and say 'no' to code of conduct question

copier copy --vcs-ref 464-codeconduct https://github.com/nlesc/python-template test_no

What to check:
You should see the files below only when you say 'yes':

  • CODE_OF_CONDUCT.md
  • project_setup.md should contain a reference to the code of conduct
  • CONTRIBUTING.md should contain a reference to the code of conduct

copier.yml Outdated Show resolved Hide resolved
copier.yml Outdated Show resolved Hide resolved
template/project_setup.md.jinja Outdated Show resolved Hide resolved
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
@lyashevska lyashevska marked this pull request as draft August 22, 2024 15:28
@lyashevska lyashevska marked this pull request as ready for review August 23, 2024 12:01
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 👏

@lyashevska lyashevska merged commit 5fb12b5 into main Aug 23, 2024
15 checks passed
@lyashevska lyashevska deleted the 464-codeconduct branch August 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants