-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
440-Organize copier questions #529
Conversation
… under copier/ folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @fdiblen Great work! I have made a few comments/suggestions.
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
Co-authored-by: Olga Lyashevska <olga.lyashevska@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @fdiblen I like a lot that now we have a separate 'copier' folder with all the files. This simplifies things a lot. It looks good, we can merge this and polish things separately.
Checklist
Description:
copier.yml
into multiple files and placed undercopier/
folder. Here are the new yaml files:full_name
field indocs/conf.py
Related issues:
Instructions to review the pull request
Generate packages with different feature combinations and check if you get the expected results.