Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copie_session fixture #408

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use copie_session fixture #408

wants to merge 2 commits into from

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Jul 30, 2024

Description

pytest-cookies had a cookies_session fixture, but pytest-copie did not yet have an equivalent when first switching from cookiecutter to copier. Since this will be added soon$^\text{tm}$, we can go back to using a dedicated fixture rather than creating such a session scoped template instance ourselves


$^\text{tm}$ once included in pytest-copie, this PR will be marked as ready

@sjvrijn sjvrijn marked this pull request as draft July 30, 2024 15:43
@sjvrijn sjvrijn changed the title Rename template folder and files in preparation of migration to copier Use copie_session fixture Jul 30, 2024
Copy link
Member

@egpbos egpbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great, but When Is This Coming Exactly?™ :P

Change request: please also remove the here import and the associated dependency (I forget its name).

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Aug 1, 2024

@egpbos good catch, pyprojroot.here references now removed.

Can't say when Soon™ is exactly, but it's active work in progress :)

Base automatically changed from dev to main August 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants